Skip to content

Conversation

@acdlite
Copy link
Collaborator

@acdlite acdlite commented Mar 12, 2020

Tests now run against both versions of these flags, using the test-www-variant command. So we can remove the manual overrides.

Tests now run against both versions of these flags, using the
test-www-variant command. So we can remove the manual overrides.
@acdlite acdlite requested a review from bvaughn March 12, 2020 16:59
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 12, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c4baa5:

Sandbox Source
gifted-bird-sbp5c Configuration

@sizebot
Copy link

sizebot commented Mar 12, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 0c4baa5

@sizebot
Copy link

sizebot commented Mar 12, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 0c4baa5

@acdlite acdlite force-pushed the remove-flag-overrides branch from d264579 to 0c4baa5 Compare March 12, 2020 17:08
@acdlite acdlite merged commit 615df43 into facebook:master Mar 12, 2020
trueadm pushed a commit to trueadm/react that referenced this pull request Mar 12, 2020
Tests now run against both versions of these flags, using the
test-www-variant command. So we can remove the manual overrides.
trueadm pushed a commit to trueadm/react that referenced this pull request Mar 12, 2020
Tests now run against both versions of these flags, using the
test-www-variant command. So we can remove the manual overrides.
trueadm pushed a commit to trueadm/react that referenced this pull request Mar 12, 2020
Tests now run against both versions of these flags, using the
test-www-variant command. So we can remove the manual overrides.
trueadm pushed a commit to trueadm/react that referenced this pull request Mar 12, 2020
Tests now run against both versions of these flags, using the
test-www-variant command. So we can remove the manual overrides.
trueadm pushed a commit to trueadm/react that referenced this pull request Mar 12, 2020
Tests now run against both versions of these flags, using the
test-www-variant command. So we can remove the manual overrides.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants