Don't use Spread in DevTools Injection#18277
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom Mar 11, 2020
Merged
Conversation
facebook-github-bot
added
React Core Team
sebmarkbage
commented
Mar 11, 2020
| bundleType: devToolsConfig.bundleType, | ||
| version: devToolsConfig.version, | ||
| rendererPackageName: devToolsConfig.rendererPackageName, | ||
| findFiberByHostInstance: devToolsConfig.findFiberByHostInstance, |
Contributor
Author
There was a problem hiding this comment.
This last line would be replaced with rendererConfig if we do https://github.com/facebook/react/pull/18233/files#r391135037
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ee144e1:
|
bvaughn
approved these changes
Mar 11, 2020
Contributor
Author
|
I believe this change should let us compile out the intermediate steps here but there's still something about how this is wired up that confuses the compiler until leave an unnecessary closure in place. I think it's because our use of closures in findHostInstanceByFiber. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this https://github.com/facebook/react/pull/18233/files#r391135037
We could encourage new arbitrary things to be added to this object through spread but that shares a namespace with our own things which risks us colliding and causing weird behavior. The Flow type defines that this is exact so to enforce that it is indeed exact, we can instead enumerate the values.
We really should be doing that everywhere in our internals, like we do with fiber cloning for example, and ideally avoid Object.assign as much as possible even in user facing APIs.
In DEV behavior I'm not as strict but this ships in PROD.