Modern Event System: Add support for internal FB Primer #18210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bba107d:
|
Details of bundled changes.Comparing: 355970a...bba107d react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
I have some questions!
packages/react-dom/src/events/__tests__/DOMModernPluginEventSystem-test.internal.js
Outdated
Show resolved
Hide resolved
packages/react-dom/src/events/__tests__/DOMModernPluginEventSystem-test.internal.js
Outdated
Show resolved
Hide resolved
trueadm
force-pushed
the
modern-event-primer
branch
from
842e2e4 to
9610878
Compare
trueadm
force-pushed
the
modern-event-primer
branch
2 times, most recently
from
b634b90 to
1445095
Compare
bvaughn
reviewed
Mar 4, 2020
packages/react-dom/src/events/__tests__/DOMModernPluginEventSystem-test.internal.js
Show resolved
Hide resolved
trueadm
force-pushed
the
modern-event-primer
branch
from
1445095 to
653c938
Compare
Address feedback Ensure click onl Fix Address feedback Fix
trueadm
force-pushed
the
modern-event-primer
branch
from
653c938 to
bba107d
Compare
bvaughn
approved these changes
Mar 4, 2020
packages/react-dom/src/events/__tests__/DOMModernPluginEventSystem-test.internal.js
Show resolved
Hide resolved
packages/react-dom/src/events/__tests__/DOMModernPluginEventSystem-test.internal.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes a new flag to be used with the modern event system:
enableLegacyFBPrimerSupport. This flag should be enabled in non-experimental internal bundles only.When this flag is enabled, we attempt to detect internal FB Primer event heuristics, so we know to defer the internal React dispatching till after Primer has run. We do this using as one-time document event listener.