Add modern event system flag + rename legacy plugin module#18073
Merged
trueadm merged 1 commit intofacebook:masterfrom Feb 19, 2020
Merged
Add modern event system flag + rename legacy plugin module#18073trueadm merged 1 commit intofacebook:masterfrom
trueadm merged 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
trueadm
force-pushed
the
roots-phase1
branch
from
9465f95 to
e408749
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
threepointone
approved these changes
Feb 19, 2020
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
Approving with a nit. Also, you're not using the new feature flag anywhere yet, so maybe it shouldn't be in this PR? Your call.
packages/react-dom/src/__tests__/ReactBrowserEventEmitter-test.internal.js
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does four things:
ReactBrowserEventEmitter-test.internal.jsa bitlistenToEventtolegacyListenToEventDOMEventPluginSystemtoDOMLegacyEventPluginSystemenableModernEventSystemflag