Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cannot read property 'sub' of undefined when navigating to plain-text pages #17848

Merged
merged 7 commits into from
Feb 2, 2020
+27 −14
Merged

Fix Cannot read property 'sub' of undefined when navigating to plain-text pages #17848

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0aafe38
Fix Cannot read property 'sub' of undefined when navigating to plain-…
wfnuser Jan 15, 2020
12ab22e
Merge branch 'master' into fix/inject-hook-code-in-plain-text-type
wfnuser Jan 30, 2020
ad3f7c0
fix: check hook is not null before emit it
wfnuser Jan 30, 2020
9d42378
fix: solve flow check
wfnuser Jan 30, 2020
47dc648
fix: check hook before setupNativStyleEditor
wfnuser Jan 30, 2020
da75276
fix: check hook not null before using it
wfnuser Feb 1, 2020
bcd3078
fix: check window.__REACT_DEVTOOLS_GLOBAL_HOOK__ not null before use …
wfnuser Feb 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: check window.__REACT_DEVTOOLS_GLOBAL_HOOK__ not null before use … 
…it in main.js
  • Loading branch information
@wfnuser
wfnuser committed Feb 1, 2020
commit bcd307860cbaf022b3eda03d092401f77bf69e5c
2 changes: 1 addition & 1 deletion packages/react-devtools-extensions/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ function createPanelIfReactLoaded() {
// When the user chooses a different node in the browser Elements tab,
// copy it over to the hook object so that we can sync the selection.
chrome.devtools.inspectedWindow.eval(
'(window.__REACT_DEVTOOLS_GLOBAL_HOOK__.$0 !== $0) ?' +
'(window.__REACT_DEVTOOLS_GLOBAL_HOOK__ && window.__REACT_DEVTOOLS_GLOBAL_HOOK__.$0 !== $0) ?' +
'(window.__REACT_DEVTOOLS_GLOBAL_HOOK__.$0 = $0, true) :' +
'false',
(didSelectionChange, evalError) => {
Expand Down