-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update babel-eslint and eslint packages #17829
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a4ae345:
|
What's up with the commas? Did we change Prettier config, or how does this work? |
Oh yeah I forgot none of the lint/format commands automatically run on-commit in this repo.
Running |
9311aa1
to
910bd85
Compare
910bd85
to
a4ae345
Compare
Here's what I don't understand. Presumably, |
IIRC CI did fail over prettier producing changes |
Summary
We need to update our eslint dependencies as they have fallen behind.
This patch updates the main
eslint
package and addseslint-config-prettier
to silence errors related to formatting, whichprettier
manages.Test Plan
yarn lint
.Notes
This diff does not update eslint plugin packages, because adding the following results in
yarn lint
failing with the attached error message.