Update Flow to 0.84 #17805
Merged
Update Flow to 0.84 #17805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 17284fd:
|
|
Why upgrade to version 0.84 specifically? |
|
They said it should be easy compared to some big breaking change after. It also gives us new inexact object syntax, which is necessary to align with fbsource and unblock RN sync fix. |
|
We should upgrade to a later version too for sure but I started with this as MVP. |
TrySound
reviewed
Jan 8, 2020
yarn.lock
Outdated
| @@ -4864,6 +4864,7 @@ eslint-plugin-no-unsafe-innerhtml@1.0.16: | |||
|
|
|||
| "eslint-plugin-react-internal@link:./scripts/eslint-rules": | |||
| version "0.0.0" | |||
| uid "" | |||
There was a problem hiding this comment.
I just ran Yarn. No idea.
Merged
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Update Flow to 0.84 * Fix violations * Use inexact object syntax in files from fbsource * Fix warning extraction to use a modern parser * Codemod inexact objects to new syntax * Tighten types that can be exact * Revert unintentional formatting changes from codemod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to v0.84 first is a first step that avoids breaking changes in subsequent versions of Flow. v0.84 includes the new inexact object syntax, which is necessary to align with fbsource and unblock RN sync fix. Afterwards we can continue updating Flow in increments.