More clear hooks warning for why a function is not considered as a component #17744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not recognized as a React component
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 33b963e:
|
yadejo
reviewed
Dec 30, 2019
| `function "${fn}" ` + | ||
| 'that is neither a React function component nor a custom ' + | ||
| 'React Hook function.' + | ||
| `If you are using ${hook} inside a functional component, make sure the function name starts with an uppercase letter`, |
There was a problem hiding this comment.
Maybe wrap ${hook} in double quotes so it's consistent with the rest of the message?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
gaearon
reviewed
Mar 30, 2020
| `function "${fn}" ` + | ||
| 'that is neither a React function component nor a custom ' + | ||
| 'React Hook function.' + | ||
| `If you are using "${hook}" inside a functional component, make sure the function name starts with an uppercase letter`, |
There was a problem hiding this comment.
- You need to add a space before this line.
- Change this to just
React component names must start with an uppercase letter.
gaearon
requested changes
Mar 30, 2020
|
Closing this. Already merged on #18881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #17736