[Flight] Move Flight DOM to a Webpack Specific Package #17372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1af0410:
|
Details of bundled changes.Comparing: 532810a...1af0410 react-flight-dom-webpack
Size changes (experimental) |
Details of bundled changes.Comparing: 532810a...1af0410 react-flight-dom-webpack
Size changes (stable) |
sebmarkbage
force-pushed
the
webpack
branch
2 times, most recently
from
f17ec52 to
7afac56
Compare
gaearon
reviewed
Nov 15, 2019
| "dependencies": { | ||
| "loose-envify": "^1.1.0", | ||
| "object-assign": "^4.1.1", | ||
| "webpack": "^4.41.2" |
gaearon
approved these changes
Nov 15, 2019
We'll have Webpack specific coupling so we need to ensure that it can be versioned separately from various Webpack versions. We'll also have builds for other bundlers in the future.
This was an integration test. We can add to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll have Webpack specific coupling so we need to ensure that it can be versioned separately from various Webpack versions. We'll also have builds for other bundlers in the future.
There's a matrix of configurations that include the server environment (node vs browser streams), client environment (browser vs RN), format (DOM vs RN), bundler (Webpack, Parcel, Rollup...) and possibly others. Each yielding a possible new build.
In practice, we only use a few of those combinations to create optimal builds.
Technically, the server doesn't have to be Webpack specific if the Babel transform is, but it might be good to have the transform be agnostic. E.g. it allows for the Node env and Webpack compile in parallel. So therefore I think it's better that the transform is agnostic and then we replace it with bundle meta data at runtime using a Webpack specific server.