Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codemod tests to it.experimental #17243

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 31, 2019

it.experimental marks that a test only works in Experimental builds.

It also asserts that a test does not work in the stable builds. The main benefit is that we're less likely to accidentally expose an experimental API before we intend. It also forces us to un-mark an experimental test once it become stable.

`it.experimental` marks that a test only works in Experimental builds.

It also asserts that a test does *not* work in the stable builds. The
main benefit is that we're less likely to accidentally expose an
experimental API before we intend. It also forces us to un- mark an
experimental test once it become stable.
@sizebot
Copy link

sizebot commented Oct 31, 2019

Size changes (experimental)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against c6d638c

@sizebot
Copy link

sizebot commented Oct 31, 2019

Size changes (stable)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against c6d638c

@acdlite acdlite requested a review from gaearon October 31, 2019 23:50
@acdlite acdlite merged commit 6dc2734 into facebook:master Nov 1, 2019
@monkindey monkindey mentioned this pull request Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants