Read current time without marking event start time #17160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DevTools hook calls `requestCurrentTime` after the commit phase has ended, which has the accidnental consequence of freezing the start time for subsequent updates. If enough time goes by, the next update will instantly expire. I'll push a fix in the next commit.
acdlite
force-pushed
the
get-current-time
branch
from
b5641c4 to
0cbbd82
Compare
|
Wow. Would never think it's DevTools causing this 😄 |
acdlite
force-pushed
the
get-current-time
branch
from
0cbbd82 to
ac6c6fe
Compare
`requestCurrentTime` is only meant to be used for updates, because subsequent calls within the same event will receive the same time. Messing this up has bad consequences. I renamed it to `requestCurrentTimeForUpdate` and created a new function that returns the current time without the batching heuristic, called `getCurrentTime`. Swapping `requestCurrentTime` for `getCurrentTime` in the DevTools hook fixes the regression test added in the previous commit.
acdlite
force-pushed
the
get-current-time
branch
from
ac6c6fe to
15e4568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestCurrentTimeis only meant to be used for updates, because subsequent calls within the same event will receive the same time. Messing this up has bad consequences.I renamed it to
requestCurrentTimeForUpdateand created a new function that returns the current time without the batching heuristic, calledgetCurrentTime.Swapping
requestCurrentTimeforgetCurrentTimein the DevTools hook fixes the regression test added in #17159.