Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable_createRoot -> createRoot in test #17107

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 16, 2019

Fixes test added in #17105, which was based on an earlier commit than the one that removed the unstable_ prefix from createRoot.

Fixes test added in facebook#17105, which was based on an earler commit than the
one that removed the `unstable_` prefix from `createRoot`.
@sizebot
Copy link

sizebot commented Oct 16, 2019

Warnings
⚠️ Base commit is broken: 6ff23f2

Size changes (stable)

Generated by 🚫 dangerJS against 2b769d6

@sizebot
Copy link

sizebot commented Oct 16, 2019

Warnings
⚠️ Base commit is broken: 6ff23f2

Size changes (experimental)

Generated by 🚫 dangerJS against 2b769d6

@acdlite acdlite merged commit d7feeb2 into facebook:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants