Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug with illegal invocation for Trusted Types #17083

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

koto
Copy link
Contributor

@koto koto commented Oct 14, 2019

trustedTypes.is* functions need to be bound to the trustedTypes object when called. This PR fixes the bug.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@sizebot
Copy link

sizebot commented Oct 14, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against a43d32b

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Oct 14, 2019

Hmm something is failing the tests.

I wonder if there’s more background on this spec decision I could learn from? Just curious.

@koto
Copy link
Contributor Author

koto commented Oct 15, 2019

There's no reason, I filed https://bugs.chromium.org/p/chromium/issues/detail?id=1014408 to track this in Chromium, but any fix we provide will take quite some time to reach Chrome stable :/

I fixed the test.

@gaearon gaearon merged commit fdba0e5 into facebook:master Oct 15, 2019
@gaearon
Copy link
Collaborator

gaearon commented Oct 15, 2019

Cool, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants