Skip to content

Conversation

@acdlite
Copy link
Collaborator

@acdlite acdlite commented Jul 10, 2019

When executing a task, wraps the callback in an extra function whose name includes the current priority level. Profiling tools with access to function names can use this to determine the priority of the task.

When executing a task, wraps the callback in an extra function whose
name includes the current priority level. Profiling tools with access
to function names can use this to determine the priority of the task.
@sizebot
Copy link

sizebot commented Jul 10, 2019

React: size: 🔺+0.8%, gzip: 🔺+0.4%

Details of bundled changes.

Comparing: 933c664...0f0eaa4

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +1.2% +0.7% 112.54 KB 113.88 KB 28.51 KB 28.71 KB UMD_DEV
react.production.min.js 🔺+0.8% 🔺+0.4% 13.15 KB 13.26 KB 5.07 KB 5.09 KB UMD_PROD
react.profiling.min.js +0.7% +0.2% 15.34 KB 15.45 KB 5.63 KB 5.65 KB UMD_PROFILING
react.development.js 0.0% -0.0% 71.36 KB 71.36 KB 18.63 KB 18.63 KB NODE_DEV
react.production.min.js 0.0% -0.0% 6.69 KB 6.69 KB 2.75 KB 2.75 KB NODE_PROD
React-dev.js 0.0% -0.0% 69.57 KB 69.57 KB 17.9 KB 17.89 KB FB_WWW_DEV
React-prod.js 0.0% -0.0% 16.86 KB 16.86 KB 4.43 KB 4.43 KB FB_WWW_PROD
React-profiling.js 0.0% -0.0% 16.86 KB 16.86 KB 4.43 KB 4.43 KB FB_WWW_PROFILING

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler-unstable_mock.development.js +6.9% +4.2% 19.58 KB 20.93 KB 4.4 KB 4.59 KB UMD_DEV
scheduler-tracing.profiling.min.js 0.0% -0.1% 3.26 KB 3.26 KB 1000 B 999 B NODE_PROFILING
scheduler-unstable_mock.production.min.js 🔺+2.0% 🔺+1.0% 5.07 KB 5.18 KB 1.99 KB 2.01 KB UMD_PROD
Scheduler-dev.js +5.6% +2.8% 26.53 KB 28.03 KB 6.81 KB 7 KB FB_WWW_DEV
Scheduler-prod.js 🔺+3.6% 🔺+1.6% 15.76 KB 16.33 KB 3.39 KB 3.45 KB FB_WWW_PROD
scheduler-tracing.development.js 0.0% -0.0% 11.11 KB 11.11 KB 2.78 KB 2.78 KB NODE_DEV
scheduler-unstable_mock.development.js +7.0% +4.2% 19.39 KB 20.74 KB 4.34 KB 4.52 KB NODE_DEV
scheduler-unstable_mock.production.min.js 🔺+2.0% 🔺+1.0% 5.06 KB 5.16 KB 1.94 KB 1.96 KB NODE_PROD
SchedulerMock-dev.js +7.6% +4.4% 19.75 KB 21.24 KB 4.43 KB 4.62 KB FB_WWW_DEV
SchedulerMock-prod.js 🔺+4.2% 🔺+2.0% 13.54 KB 14.11 KB 2.9 KB 2.96 KB FB_WWW_PROD
scheduler.development.js +5.2% +2.7% 26.12 KB 27.46 KB 6.72 KB 6.9 KB NODE_DEV
scheduler.production.min.js 🔺+1.8% 🔺+0.9% 5.79 KB 5.9 KB 2.16 KB 2.18 KB NODE_PROD

Generated by 🚫 dangerJS

@acdlite acdlite force-pushed the scheduler-priority-stack branch 4 times, most recently from 1c87cd8 to 0f0eaa4 Compare July 10, 2019 22:39
@acdlite acdlite merged commit d2d9b1f into facebook:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants