[Flare] Press includes button type #16100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
necolas
commented
Jul 10, 2019
necolas
commented
- Allow auxillary button clicks (i.e., middle mouse button) to trigger 'onPressStart' and 'onPressEnd', but never 'onPress'.
- Report the button type – 'primary' or 'auxillary' – on the press event.
necolas
commented
Jul 10, 2019
1. Allow auxillary button clicks (i.e., middle mouse button) to trigger 'onPressStart' and 'onPressEnd', but never 'onPress'. 2. Report the button type – 'primary' or 'auxillary' – on the press event.
necolas
force-pushed
the
react-events/press-button-type
branch
from
9e57047 to
0d7e972
Compare
trueadm
approved these changes
Jul 10, 2019
Contributor
trueadm
left a comment
trueadm
left a comment
There was a problem hiding this comment.
Added nit. Looks good :)
| if (state.isPressWithinResponderRegion) { | ||
| if ( | ||
| state.isPressWithinResponderRegion && | ||
| nativeEvent.button !== 1 |
Contributor
There was a problem hiding this comment.
Can we hoist button out and re-use it for both conditions?
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.