Un-mixin ReactBrowserComponentMixin from ReactTextComponent #1598
Conversation
|
Yea that seems right. No rush since you can't get a handle on this anyway, right? |
|
@sebmarkbage Not legitimately anyway. |
|
Anything more need to be done here besides rebase? We apparently took that "no rush" to heart… |
|
Doubt it, but I'll run some tests and verify that nothing breaks. |
|
Rebased. EDIT: Might be worth sticking this in the changelog too, if someone for some reason was calling |
| .toBeTextComponent() | ||
| .instance(); | ||
|
|
||
| var textNode = d.getDOMNode().childNodes[i].firstChild; |
There was a problem hiding this comment.
Lint complains that textNode is already defined, want to fix that?
There was a problem hiding this comment.
No... but I fixed it anyway ;)
Un-mixin ReactBrowserComponentMixin from ReactTextComponent
It's no longer used as of facebook#1598, which just missed the require. Test Plan: build, jest
ReactTextComponent having
getDOMNodeis an implementation detail, it's also very likely that it won't support it in the future (and since it's technically not always a span, it's even wrong in some sense today).PS. Can you even access it today without cheating your way in and using private members? I don't think so...