Clean up data-react-checksum after checksum match #1578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't |
|
@spicyj Yeah you're right, I confused the JavaScript (and PHP) type-casting rules, There's no advantage to removing the attribute other than "cleanliness". |
syranide
changed the title
4 tasks
|
I like the initiative :) But meh. Let's come back to it if we go with that clean DOM thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily to go with #1570, (then) the final DOM would be completely clean of React markup in the end, even if you use server-rendering. Which I think would be nice given that it's virtually for free.
Not that it really matters, but I also made it safe to use with any hash (not just a numeric one), it should also save a byte or two in size.