Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React events: consolidate logic of Hover event component #15450

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Apr 19, 2019

Stacks on #15449. Demo integrating this patch: https://fburl.com/nfye4390

Minor refactor of Hover and additional regression coverage.

Ref #15257

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI seems to be failing here.

@necolas
Copy link
Contributor Author

necolas commented Apr 19, 2019

It should start passing once I merge the commit it depends on

@necolas necolas force-pushed the react-events/hover-consolidation branch from f6272a8 to fd689e6 Compare April 19, 2019 15:49
@sizebot
Copy link

sizebot commented Apr 19, 2019

Details of bundled changes.

Comparing: 5857c89...fd689e6

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js 0.0% -0.3% 1.59 KB 1.59 KB 687 B 685 B UMD_DEV
react-events.production.min.js 0.0% -0.4% 857 B 857 B 477 B 475 B UMD_PROD
react-events.development.js 0.0% -0.2% 1.4 KB 1.4 KB 624 B 623 B NODE_DEV
react-events.production.min.js 0.0% -0.3% 698 B 698 B 400 B 399 B NODE_PROD
react-events-press.development.js 0.0% -0.0% 20.45 KB 20.45 KB 4.77 KB 4.77 KB UMD_DEV
react-events-press.production.min.js 0.0% -0.0% 7.75 KB 7.75 KB 2.64 KB 2.64 KB UMD_PROD
react-events-press.development.js 0.0% -0.0% 20.28 KB 20.28 KB 4.73 KB 4.73 KB NODE_DEV
react-events-press.production.min.js 0.0% -0.0% 7.58 KB 7.58 KB 2.59 KB 2.59 KB NODE_PROD
react-events-hover.development.js +13.3% +12.9% 8.29 KB 9.39 KB 2.07 KB 2.34 KB UMD_DEV
react-events-hover.production.min.js 🔺+7.1% 🔺+9.9% 3.54 KB 3.79 KB 1.3 KB 1.42 KB UMD_PROD
react-events-hover.development.js +13.5% +12.9% 8.12 KB 9.22 KB 2.03 KB 2.3 KB NODE_DEV
react-events-hover.production.min.js 🔺+7.6% 🔺+10.9% 3.38 KB 3.63 KB 1.25 KB 1.38 KB NODE_PROD
ReactEventsHover-dev.js +12.0% +12.7% 8.23 KB 9.21 KB 2.04 KB 2.3 KB FB_WWW_DEV
ReactEventsHover-prod.js 🔺+7.4% 🔺+10.4% 6.88 KB 7.39 KB 1.61 KB 1.78 KB FB_WWW_PROD
react-events-focus.development.js 0.0% -0.1% 4.06 KB 4.06 KB 1.33 KB 1.33 KB UMD_DEV
react-events-focus.production.min.js 0.0% -0.1% 1.65 KB 1.65 KB 788 B 787 B UMD_PROD
react-events-focus.development.js 0.0% -0.1% 3.89 KB 3.89 KB 1.29 KB 1.29 KB NODE_DEV
react-events-focus.production.min.js 0.0% -0.3% 1.49 KB 1.49 KB 724 B 722 B NODE_PROD
react-events-swipe.development.js 0.0% -0.0% 8.43 KB 8.43 KB 2.63 KB 2.62 KB UMD_DEV
react-events-swipe.production.min.js 0.0% -0.1% 3.46 KB 3.46 KB 1.61 KB 1.61 KB UMD_PROD
react-events-swipe.development.js 0.0% -0.0% 8.26 KB 8.26 KB 2.59 KB 2.59 KB NODE_DEV
react-events-swipe.production.min.js 0.0% -0.1% 3.3 KB 3.3 KB 1.55 KB 1.55 KB NODE_PROD
react-events-drag.development.js 0.0% -0.0% 7.96 KB 7.96 KB 2.51 KB 2.51 KB UMD_DEV
react-events-drag.development.js 0.0% -0.0% 7.79 KB 7.79 KB 2.47 KB 2.47 KB NODE_DEV
react-events-drag.production.min.js 0.0% -0.1% 3.17 KB 3.17 KB 1.45 KB 1.45 KB NODE_PROD

Generated by 🚫 dangerJS

@necolas necolas merged commit cdfce1a into facebook:master Apr 19, 2019
@necolas necolas deleted the react-events/hover-consolidation branch April 19, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants