Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental Event API: preventDefault handling for anchors #15383

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Experimental Event API: preventDefault handling for anchors #15383

merged 1 commit into from
Apr 11, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Apr 11, 2019 •
edited by necolas
Loading

This PR adds preventDefault handling for <a> tag to the Press event responder module. The behaviour takes into account keyboard modifiers (shift, control and command). It also allows a low-level bypass for when anchor tags should not be default prevented via the preventDefault prop.

Ref #15257

@trueadm trueadm requested a review from necolas April 11, 2019 10:21
@trueadm trueadm requested a review from threepointone April 11, 2019 10:59
@trueadm trueadm merged commit c984100 into facebook:master Apr 11, 2019
@trueadm trueadm deleted the prevent-default-anchors branch April 11, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threepointone threepointone threepointone approved these changes

@necolas necolas Awaiting requested review from necolas

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueadm @threepointone @facebook-github-bot