Skip to content

Experimental Event API: Add targets and responder utility method for finding targets #15372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 10, 2019
Merged

Experimental Event API: Add targets and responder utility method for finding targets #15372

merged 5 commits into from
Apr 10, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Apr 10, 2019 •
edited by necolas
Loading

Note: the experimental event API is for internal purposes only right now

This PR adds two new event targets that recently came up in discussion. They're not used or have any specific code paths yet, but they will do in the future. They are FocusTarget and PressTarget.

Furthermore, a new helper method on the event responder context has been added: getEventTargetsFromTarget. This method can query the internal fiber tree to find event targets and their associated host components and props – given the optional type and key query arguments.

Ref #15257

@trueadm trueadm requested a review from necolas April 10, 2019 14:36
@trueadm trueadm changed the title Adds more EventTargets and the getEventTargetsFromTarget utility Experimental Event API: Add targets and responder utility method for finding targets Apr 10, 2019
@sizebot
Copy link

sizebot commented Apr 10, 2019 •
edited
Loading

React: size: 0.0%, gzip: 0.0%

ReactDOM: size: -0.1%, gzip: -0.1%

Details of bundled changes.

Comparing: c64b330...d9aec50

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +0.5% +0.4% 106.85 KB 107.38 KB 27.05 KB 27.16 KB UMD_DEV
react.production.min.js 0.0% 0.0% 12.01 KB 12.01 KB 4.64 KB 4.64 KB UMD_PROD
react.development.js +0.8% +0.5% 69.61 KB 70.14 KB 17.98 KB 18.07 KB NODE_DEV
React-dev.js +0.8% +0.7% 68 KB 68.53 KB 17.33 KB 17.45 KB FB_WWW_DEV
React-prod.js -0.3% -0.3% 16.07 KB 16.02 KB 4.25 KB 4.24 KB FB_WWW_PROD
React-profiling.js -0.3% -0.3% 16.07 KB 16.02 KB 4.25 KB 4.24 KB FB_WWW_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.3% +0.3% 892.95 KB 895.36 KB 201.88 KB 202.45 KB UMD_DEV
react-dom.production.min.js -0.1% -0.1% 105.4 KB 105.32 KB 34.1 KB 34.07 KB UMD_PROD
react-dom.profiling.min.js -0.1% -0.0% 108.41 KB 108.33 KB 34.71 KB 34.7 KB UMD_PROFILING
react-dom.development.js +0.3% +0.3% 887.58 KB 889.99 KB 200.31 KB 200.9 KB NODE_DEV
react-dom.production.min.js -0.1% -0.1% 105.39 KB 105.31 KB 33.59 KB 33.55 KB NODE_PROD
react-dom.profiling.min.js -0.1% -0.1% 108.51 KB 108.43 KB 34.15 KB 34.12 KB NODE_PROFILING
ReactDOM-dev.js +0.3% +0.3% 913.52 KB 915.94 KB 202.07 KB 202.63 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.5% 🔺+0.5% 337.38 KB 339.13 KB 62.08 KB 62.41 KB FB_WWW_PROD
ReactDOM-profiling.js +0.5% +0.5% 344.46 KB 346.21 KB 63.52 KB 63.85 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js +0.3% +0.3% 893.27 KB 895.68 KB 202.01 KB 202.59 KB UMD_DEV
react-dom-unstable-fire.production.min.js -0.1% -0.1% 105.42 KB 105.34 KB 34.1 KB 34.08 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js -0.1% -0.0% 108.42 KB 108.34 KB 34.72 KB 34.71 KB UMD_PROFILING
react-dom-unstable-fire.development.js +0.3% +0.3% 887.9 KB 890.31 KB 200.45 KB 201.03 KB NODE_DEV
react-dom-unstable-fire.production.min.js -0.1% -0.1% 105.41 KB 105.33 KB 33.6 KB 33.56 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js -0.1% -0.1% 108.53 KB 108.45 KB 34.16 KB 34.13 KB NODE_PROFILING
ReactFire-dev.js +0.3% +0.3% 912.71 KB 915.13 KB 202.11 KB 202.69 KB FB_WWW_DEV
ReactFire-prod.js 🔺+0.5% 🔺+0.6% 326.04 KB 327.79 KB 59.77 KB 60.13 KB FB_WWW_PROD
ReactFire-profiling.js +0.5% +0.6% 333.07 KB 334.81 KB 61.16 KB 61.51 KB FB_WWW_PROFILING
react-dom-unstable-new-scheduler.development.js +0.3% +0.3% 886.08 KB 888.49 KB 199.73 KB 200.29 KB NODE_DEV
react-dom-unstable-new-scheduler.production.min.js -0.1% -0.1% 103.57 KB 103.49 KB 33.08 KB 33.04 KB NODE_PROD
react-dom-unstable-new-scheduler.profiling.min.js -0.1% -0.1% 106.91 KB 106.83 KB 33.96 KB 33.92 KB NODE_PROFILING
ReactDOMNewScheduler-dev.js +0.3% +0.3% 913.55 KB 915.97 KB 202.07 KB 202.64 KB FB_WWW_DEV
ReactDOMNewScheduler-prod.js 🔺+0.5% 🔺+0.5% 332.16 KB 333.91 KB 61.74 KB 62.08 KB FB_WWW_PROD
ReactDOMNewScheduler-profiling.js +0.5% +0.5% 337.42 KB 339.17 KB 62.76 KB 63.09 KB FB_WWW_PROFILING
react-dom-test-utils.development.js +3.0% +4.8% 52.68 KB 54.29 KB 14.33 KB 15.02 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.52 KB 10.52 KB 3.9 KB 3.9 KB UMD_PROD
react-dom-test-utils.development.js +3.1% +4.8% 52.41 KB 54.01 KB 14.26 KB 14.96 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 10.31 KB 10.31 KB 3.82 KB 3.82 KB NODE_PROD
ReactTestUtils-dev.js +1.9% +2.3% 50.66 KB 51.61 KB 13.62 KB 13.93 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.76 KB 60.76 KB 15.85 KB 15.85 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.43 KB 60.43 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.42 KB 10.42 KB 3.56 KB 3.56 KB NODE_PROD
react-dom-server.browser.development.js +0.4% +0.2% 136.52 KB 137.02 KB 35.92 KB 36 KB UMD_DEV
react-dom-server.browser.production.min.js -0.3% -0.4% 19.24 KB 19.18 KB 7.24 KB 7.21 KB UMD_PROD
react-dom-server.browser.development.js +0.4% +0.2% 132.65 KB 133.15 KB 34.99 KB 35.06 KB NODE_DEV
react-dom-server.browser.production.min.js -0.3% -0.3% 19.17 KB 19.1 KB 7.23 KB 7.2 KB NODE_PROD
ReactDOMServer-dev.js +0.4% +0.2% 135.04 KB 135.53 KB 34.69 KB 34.76 KB FB_WWW_DEV
ReactDOMServer-prod.js 🔺+0.7% 🔺+0.5% 47.7 KB 48.04 KB 10.95 KB 11 KB FB_WWW_PROD
react-dom-server.node.development.js +0.4% +0.2% 134.59 KB 135.1 KB 35.53 KB 35.61 KB NODE_DEV
react-dom-server.node.production.min.js -0.3% -0.2% 20.03 KB 19.96 KB 7.53 KB 7.51 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.66 KB 3.66 KB 1.45 KB 1.45 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 706 B 705 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.49 KB 3.49 KB 1.41 KB 1.41 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.74 KB 3.74 KB 1.43 KB 1.43 KB NODE_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.1% 638.72 KB 639.48 KB 138.04 KB 138.25 KB UMD_DEV
react-art.production.min.js -0.1% -0.1% 97.1 KB 97.02 KB 29.69 KB 29.67 KB UMD_PROD
react-art.development.js +0.1% +0.1% 569.93 KB 570.69 KB 120.76 KB 120.92 KB NODE_DEV
react-art.production.min.js -0.1% -0.1% 62.13 KB 62.05 KB 18.94 KB 18.93 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 580.84 KB 581.58 KB 120.39 KB 120.51 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.2% 🔺+0.3% 197.88 KB 198.36 KB 33.52 KB 33.6 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.1% +0.1% 714.4 KB 715.15 KB 151.15 KB 151.32 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.1% -0.2% 248.51 KB 248.16 KB 43.01 KB 42.93 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.1% -0.2% 255.07 KB 254.72 KB 44.38 KB 44.31 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js +0.1% +0.1% 714.32 KB 715.06 KB 151.12 KB 151.29 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.1% -0.2% 248.53 KB 248.17 KB 43.01 KB 42.93 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.1% -0.2% 255.09 KB 254.74 KB 44.38 KB 44.31 KB RN_OSS_PROFILING
ReactFabric-dev.js +0.1% +0.1% 703.1 KB 703.85 KB 148.45 KB 148.6 KB RN_FB_DEV
ReactFabric-prod.js -0.1% -0.2% 241.83 KB 241.47 KB 41.7 KB 41.63 KB RN_FB_PROD
ReactFabric-profiling.js -0.1% -0.2% 247.74 KB 247.38 KB 43.04 KB 42.97 KB RN_FB_PROFILING
ReactFabric-dev.js +0.1% +0.1% 703.01 KB 703.75 KB 148.41 KB 148.57 KB RN_OSS_DEV
ReactFabric-prod.js -0.1% -0.2% 241.83 KB 241.48 KB 41.7 KB 41.62 KB RN_OSS_PROD
ReactFabric-profiling.js -0.1% -0.2% 247.75 KB 247.4 KB 43.04 KB 42.96 KB RN_OSS_PROFILING

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.1% 584.46 KB 585.22 KB 123.99 KB 124.13 KB UMD_DEV
react-test-renderer.production.min.js -0.1% -0.2% 63.42 KB 63.34 KB 19.4 KB 19.37 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 580.08 KB 580.84 KB 122.84 KB 122.98 KB NODE_DEV
react-test-renderer.production.min.js -0.1% -0.2% 63.14 KB 63.06 KB 19.2 KB 19.17 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 592.54 KB 593.29 KB 123.01 KB 123.16 KB FB_WWW_DEV
react-test-renderer-shallow.development.js +5.3% +8.0% 39.85 KB 41.98 KB 9.96 KB 10.75 KB UMD_DEV
react-test-renderer-shallow.production.min.js -0.6% -1.0% 11.7 KB 11.63 KB 3.59 KB 3.55 KB UMD_PROD
react-test-renderer-shallow.development.js +6.3% +9.6% 34.08 KB 36.21 KB 8.58 KB 9.41 KB NODE_DEV
react-test-renderer-shallow.production.min.js -0.6% -0.9% 11.89 KB 11.81 KB 3.7 KB 3.67 KB NODE_PROD
ReactShallowRenderer-dev.js +4.3% +5.0% 33.82 KB 35.29 KB 8.4 KB 8.82 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% +0.2% 573.11 KB 573.87 KB 120.31 KB 120.5 KB NODE_DEV
react-reconciler.production.min.js -0.1% -0.2% 63.14 KB 63.07 KB 18.77 KB 18.73 KB NODE_PROD
react-reconciler-persistent.development.js +0.1% +0.1% 570.91 KB 571.67 KB 119.41 KB 119.56 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.1% -0.2% 63.15 KB 63.08 KB 18.77 KB 18.74 KB NODE_PROD
react-reconciler-reflection.development.js +12.4% +15.7% 17.15 KB 19.28 KB 5.21 KB 6.03 KB NODE_DEV

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js +37.2% +11.2% 1.16 KB 1.59 KB 617 B 686 B UMD_DEV
react-events.production.min.js 🔺+25.7% 🔺+10.4% 682 B 857 B 431 B 476 B UMD_PROD
react-events.development.js +44.4% +12.4% 996 B 1.4 KB 555 B 624 B NODE_DEV
react-events.production.min.js 🔺+36.3% 🔺+13.3% 512 B 698 B 353 B 400 B NODE_PROD
ReactEvents-dev.js +47.1% +12.7% 956 B 1.37 KB 536 B 604 B FB_WWW_DEV
ReactEvents-prod.js 🔺+66.7% 🔺+18.0% 687 B 1.12 KB 410 B 484 B FB_WWW_PROD
react-events-press.development.js 0.0% -0.1% 12.88 KB 12.88 KB 3.02 KB 3.02 KB UMD_DEV
react-events-press.production.min.js 0.0% -0.1% 5.11 KB 5.11 KB 1.73 KB 1.73 KB UMD_PROD
react-events-press.development.js 0.0% -0.1% 12.71 KB 12.71 KB 2.98 KB 2.98 KB NODE_DEV
react-events-press.production.min.js 0.0% -0.1% 4.94 KB 4.94 KB 1.68 KB 1.68 KB NODE_PROD
react-events-hover.development.js 0.0% -0.1% 6.74 KB 6.74 KB 1.79 KB 1.79 KB UMD_DEV
react-events-hover.development.js 0.0% -0.1% 6.57 KB 6.57 KB 1.75 KB 1.74 KB NODE_DEV
react-events-hover.production.min.js 0.0% -0.1% 2.85 KB 2.85 KB 1.1 KB 1.1 KB NODE_PROD
react-events-focus.development.js 0.0% -0.2% 3.29 KB 3.29 KB 1.11 KB 1.11 KB UMD_DEV
react-events-focus.production.min.js 0.0% 🔺+0.3% 1.52 KB 1.52 KB 739 B 741 B UMD_PROD
react-events-focus.development.js 0.0% -0.2% 3.12 KB 3.12 KB 1.06 KB 1.06 KB NODE_DEV
react-events-swipe.development.js 0.0% -0.0% 8.29 KB 8.29 KB 2.57 KB 2.57 KB UMD_DEV
react-events-swipe.production.min.js 0.0% -0.1% 3.29 KB 3.29 KB 1.55 KB 1.55 KB NODE_PROD
react-events-drag.development.js 0.0% -0.1% 7.8 KB 7.8 KB 2.44 KB 2.44 KB UMD_DEV
react-events-drag.production.min.js 0.0% -0.1% 3.3 KB 3.3 KB 1.5 KB 1.5 KB UMD_PROD
react-events-drag.development.js 0.0% -0.0% 7.63 KB 7.63 KB 2.4 KB 2.4 KB NODE_DEV
react-events-drag.production.min.js 0.0% -0.1% 3.14 KB 3.14 KB 1.44 KB 1.44 KB NODE_PROD

Generated by 🚫 dangerJS

@trueadm trueadm merged commit dd9cef9 into facebook:master Apr 10, 2019
@trueadm trueadm deleted the expand-on-event-targets branch April 10, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas necolas approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueadm @sizebot @necolas @facebook-github-bot