Skip to content

Conversation

@lrowe
Copy link
Contributor

@lrowe lrowe commented Jul 3, 2013

No description provided.

@zpao
Copy link
Member

zpao commented Jul 3, 2013

Awesome! Can you rebase? 32423a8 moved things around so this doesn't apply cleanly anymore.

@lrowe
Copy link
Contributor Author

lrowe commented Jul 3, 2013

Updated the patch. Running the tests gives me the same error as on master:

Running "phantom:run" (phantom) task
Error while invoking `findComponentRoot` with the following ancestor node: [object Object]

createMarkupForProperty: it should create markup for simple properties
Error: Invariant Violation: EventPluginRegistry: Cannot inject event plugin ordering more than once. in http://localhost:8080/react-test.js (line 21547)

TypeError: 'undefined' is not a function (near '...}.bind(this));...')

  http://localhost:8080/jasmine.js:3884
PhantomJS tests timed out after 60 seconds.

@zpao
Copy link
Member

zpao commented Jul 3, 2013

Not your fault. We have a bug with some of our testing infra - #155

zpao added a commit that referenced this pull request Jul 3, 2013
Add `hidden` attribute to DOM properties.
@zpao zpao merged commit 4e04ef0 into facebook:master Jul 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants