Adds React event component and React event target support to SSR renderer#15242
Merged
trueadm merged 3 commits intofacebook:masterfrom Mar 28, 2019
Merged
Adds React event component and React event target support to SSR renderer#15242trueadm merged 3 commits intofacebook:masterfrom
trueadm merged 3 commits intofacebook:masterfrom
Conversation
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: fb6b508...841ca0f react-dom
Generated by 🚫 dangerJS |
trueadm
commented
Mar 28, 2019
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @emails react-core | ||
| * @jest-environment node |
Contributor
Author
There was a problem hiding this comment.
This existed from a copy and paste from a previous test file. We don't want it here as we want Jest to give the JSDOM for document and using this setting removes JSDOM support for this test.
sebmarkbage
reviewed
Mar 28, 2019
sebmarkbage
approved these changes
Mar 28, 2019
Contributor
sebmarkbage
left a comment
sebmarkbage
left a comment
There was a problem hiding this comment.
Nit: Let's throw if not enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is for an experimental event API that we're testing out internally at Facebook.
This PR adds support for server side rendering for the experimental event API along with tests. I also added some ReactDOM renderer tests to the same test file to be consistent and give more coverage.
#15036
#15112
#15150
#15168
#15179
#15228