Skip to content

Disable JS urls at build level for www #15230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Disable JS urls at build level for www #15230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/shared/forks/ReactFeatureFlags.www.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export const {
debugRenderPhaseSideEffectsForStrictMode,
replayFailedUnitOfWorkWithInvokeGuardedCallback,
warnAboutDeprecatedLifecycles,
disableJavaScriptURLs,
disableYielding,
disableInputAttributeSyncing,
warnAboutShorthandPropertyCollision,
Expand All @@ -39,6 +38,8 @@ export const enableStableConcurrentModeAPIs = false;

export const enableSuspenseServerRenderer = true;

export const disableJavaScriptURLs = true;

// I've chosen to make this a static flag instead of a dynamic flag controlled
// by a GK so that it doesn't increase bundle size. It should still be easy
// to rollback by reverting the commit that turns this on.
Expand Down