Skip to content

Conversation

@syranide
Copy link
Contributor

Related #445

Kind of hacky, but very simple and robust if this is something we want to commit to.

Could easily make it configurable (certainly preferable), but I'm not familiar with the code/modules that makes up the JSX runnable and there doesn't seem to be an intuitive way of accessing options in the visitors themselves.

@zpao
Copy link
Member

zpao commented May 13, 2014

Yea, would definitely need to make this configurable before we could take it.

@sophiebits
Copy link
Collaborator

I know @andreypopp has a fork of eslint that works with JSX; if it can be packaged up maybe it's worth just suggesting people use that so we don't need to worry about the quoting debate:

https://github.com/andreypopp/eslint/tree/jsx

@tcoopman
Copy link

I think it would be nice to have this feature though. There are lots of other tools (jshint, jscs,..) and I'm not sure that forking all of these is the way to go. It would be nice if the output of the generated JSX could pass linting.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sophiebits
Copy link
Collaborator

We aren't going to merge this in its current form at least, so I'm closing this out for now.

@sophiebits sophiebits closed this Jun 13, 2014
@syranide syranide mentioned this pull request Jun 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants