Removed Fabric-specific feature flag files and updated Rollup to use … #14437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the (non-Fabric) React Native flag files.
sebmarkbage
approved these changes
Dec 14, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…the (non-Fabric) React Native flag files. (facebook#14437)
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
…the (non-Fabric) React Native flag files. (facebook#14437)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Fabric-specific feature flag files and updated Rollup to use the (non-Fabric) React Native flag files. Since the
supportsPersistencesetting now resides in the renderer's "host config", there's no reason for these two to have separate flag forks.There were no differences between OSS React Native and Fabric flags.
There were a few differences between FB React Native and Fabric flags:
debugRenderPhaseSideEffectsfalsedebugRenderPhaseSideEffectsForStrictModetruefalsewarnAboutDeprecatedLifecyclestruefalse(As of this PR, Fabric will now get the React Native flag values shown above.)