Promote a canary from NPM to be a stable release #14255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 13, 2018 15:38
Also updated Circle CI build script to generate and add a build-info.json file to artifacts
bvaughn
changed the title
31 tasks
matpag
reviewed
Nov 17, 2018
| `cp -r ${tempDirectory}/build/node_modules/*.tgz ${cwd}/build/node_modules/` | ||
| ); | ||
|
|
||
| // Unpack packages and parepare to publish. |
matpag
reviewed
Nov 17, 2018
| const {getBuildInfo, handleError} = require('./utils'); | ||
|
|
||
| // This local build script exists for special case, manual builds. | ||
| // The typical suggesgted release process is to create a canary from a CI artifact. |
matpag
reviewed
Nov 17, 2018
| // If the source dependency's version and the constraint match, | ||
| // we will need to update the constraint to point at the dependency's new release version, | ||
| // (e.g. scheduler@^0.11.0 becomes scheduler@^0.12.0 when we release scheduler 0.12.0). | ||
| // Othewise we leave the constraint alone (e.g. react@^16.0.0 doesn't change between releases). |
matpag
reviewed
Nov 17, 2018
| // Update all package JSON versions and their dependencies/peerDependencies. | ||
| // This must be done in a way that respects semver constraints (e.g. 16.7.0, ^16.7.0, ^16.0.0). | ||
| // To do this, we use the dependencies defined in the source package JSONs, | ||
| // because the canary dependencies have already been falttened to an exact match (e.g. 0.0.0-ddaf2b07c). |
|
Thanks. I can't type. I'll fix those. |
|
Typo fixes included in next PR, #14260 |
|
tried running this, what do you suppose I'm doing wrong? |
|
I'm guessing you didn't actually publish the canary you're trying to promote to stable 😄 You can either run with a |
|
Already merged via #14260 |
|
aha that's what it was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #14201. Builds on top of #14244 (view the delta).
New script to prepare a canary release to be promoted to stable. This script checks out canary packages from NPM, prompts for new stable versions, and updates the versions (including dependencies) in the checked-out packages.
Learn more about these new release scripts here.