Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set the first option as selected in select tag with size attribute #14242

Merged
merged 3 commits into from
Mar 14, 2019
Merged

Don't set the first option as selected in select tag with size attribute #14242

merged 3 commits into from
Mar 14, 2019

Commits on Nov 15, 2018

  1. Set 'size' attribute to select tag if it occurs before appending options

    @kulek1
    kulek1 committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    19a214e View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. Add comment about why size is assigned on select create. Tests 

    I added some more clarification for why size must be set on select
element creation:

- In the source code
- In the DOM test fixture
- In a unit test
    @nhunzaker
    nhunzaker committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    b3acfd9 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Use let, not const in select tag stub assignment

    @nhunzaker
    nhunzaker committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    fa175ca View commit details
    Browse the repository at this point in the history