Skip to content

Conversation

@imbhargav5
Copy link

@imbhargav5 imbhargav5 commented Oct 17, 2018

Aims to fix #13864

  • Add warning message within reconciler
  • Add test case to show a warning when fallback prop is missing.
  • Fix the many test cases which do not have fallback as a prop in jest development environment. How should I go about this?

Should I add a fallback={null} prop for existing test cases which don't have a fallback prop defined or should I add an expect().toWarnDev to all of them?

@sizebot
Copy link

sizebot commented Oct 17, 2018

Details of bundled changes.

Comparing: 7685b55...f09c2f5

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@sebmarkbage
Copy link
Collaborator

I believe this was effectively fixed by #13879 since it should now error if there is no fallback specified anywhere above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suspense component should only capture if fallback prop is defined

4 participants