Skip to content

Conversation

@georgesisco
Copy link
Contributor

The following steps also have an ajax function, but the 'error:' param
is gone after step 13:
step 14
step 17
step 19
step 20
This may be superfluous, but it helped me find an error with something I
was doing - Namely, in my .json file, I had single line javascript
comments ("//") that I copied from the tutorial. I couldn't find the
issue on later steps, but was able to see my issue when the error
handler complained about an unexpected "/" in my file in step step 13.

… steps

The following steps also have an ajax function, but the 'error:' param
is gone after facebook#13:
facebook#14
facebook#17
facebook#19
facebook#20
This may be superfluous, but it helped me find an error with something I
was doing - Namely, in my .json file, I had single line javascript
comments ("//") that I copied from the tutorial. I couldn't find the
issue on later steps, but was able to see my issue when the error
handler complained about an unexpected "/" in my file in step facebook#13.
@georgesisco georgesisco changed the title Carry ajax error checking from step #13 forward to other ajax steps In the tutorial, Carry ajax error checking from step #13 forward to other ajax steps Apr 9, 2014
@georgesisco georgesisco changed the title In the tutorial, Carry ajax error checking from step #13 forward to other ajax steps In the tutorial, carry ajax error checking from step #13 forward to other ajax steps Apr 9, 2014
@georgesisco georgesisco changed the title In the tutorial, carry ajax error checking from step #13 forward to other ajax steps In the tutorial, carry ajax error checking from step 13 forward to other ajax steps Apr 9, 2014
@zpao zpao added the CLA signed label Apr 9, 2014
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you take a look at line 414 above, you see we have some references to line numbers (looks like {3,16-17,31}) - these allow us to do highlighting of certain lines on the website. Since you're adding lines in the middle here and later, we need to adjust the line numbers so the same thing stays highlighted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I completely missed that. Let me fix that up and push the file again. Thanks for the help!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zpao, I've updated the file. Would you take a look? I spent a while trying to figure out how to preview it in it's final form, but I finally just copied each snippet into my editor and grabbed the line numbers from there.

@zpao
Copy link
Member

zpao commented Apr 14, 2014

This looks great, thanks for updating!

zpao added a commit that referenced this pull request Apr 14, 2014
In the tutorial, carry ajax error checking from step 13 forward to other ajax steps
@zpao zpao merged commit 34c9e14 into facebook:master Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants