Fix 'flow-coverage-report' command. #13393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`flow-coverage-report` stopped working after Flow was set to run for each renderer separately (facebook#12846). It happened because `flow-coverage-report` calls `flow coverage`, and that command doesn't work without a `.flowconfig` in a parent directory of every file checked. This is fixed by creating a temporary `.flowconfig` in the project root before running `flow-coverage-report`. This fix also allows to move `.flowcoverage` out of the project root, and to select a renderer before generating the coverage report. Internally, this is done by rewriting `writeConfig()` to accept a `rootFolder` argument. If `rootFolder` is true, a config is made in the root folder, with the right relative paths.
|
Thanks for the PR! The libs substitution is more complex than I would like.. Ideally we want to avoid as much abstraction as we can there. Maybe let's just remove this script? We don't really use it. Or find some other solution that doesn't involve making the config more abstract. |
|
Yes, makes sense. I don't think there's a way to solve this without adding complexity to |
elas7
added a commit
to elas7/react
that referenced
this pull request
Aug 14, 2018
`flow-coverage-report` stopped working after Flow was set to run for each renderer separately (facebook#12846). As discussed in facebook#13393, this is hard to fix without adding complexity to `.flowconfig`'s generation.
gaearon
pushed a commit
that referenced
this pull request
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flow-coverage-reportstopped working after Flow was set to run for each renderer separately (#12846). It happened becauseflow-coverage-reportcallsflow coverage, and that command doesn't work without a.flowconfigin a parent directory of every file checked.This is fixed by creating a temporary
.flowconfigin the project root before runningflow-coverage-report.This fix also allows to move
.flowcoverageout of the project root, and to select a renderer before generating the coverage report.Internally, this is done by rewriting
writeConfig()to accept arootFolderargument. IfrootFolderis true, a config is made in the root folder, with the right relative paths.Before
After
