Adds semver to the package dev dependencies #12442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Mar 23, 2018
package.json
Outdated
| @@ -119,5 +119,8 @@ | |||
| "prettier": "node ./scripts/prettier/index.js write-changed", | |||
| "prettier-all": "node ./scripts/prettier/index.js write", | |||
| "version-check": "node ./scripts/tasks/version-check.js" | |||
| }, | |||
| "dependencies": { | |||
| "semver": "^5.5.0" | |||
There was a problem hiding this comment.
Maybe move to devDependencies with the others?
There was a problem hiding this comment.
Done 👍
fwiw devDependencies on workspace top-level aren't really useful, since workspaces are typically always installed on development environment (we do however respect them, so if you run yarn --production from the root, we won't install them, which will make your scripts unusable).
Branch: semver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff simply adds
semverto the top-level dev dependencies. Semver was used in various scripts (ex here) without being listed, which was invalid (it worked because one of React's dependencies was itself depending on semver, which was then hoisted to the top-level through package managers optimizations).