Format danger percents better #12256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
approved these changes
Feb 20, 2018
| return `+${change}%`; | ||
| if (!isFinite(change)) { | ||
| // When a new package is created | ||
| return 'n/a'; |
There was a problem hiding this comment.
Maybe (new)? I don't feel strongly
dangerfile.js
Outdated
| } else { | ||
| return `${change}%`; | ||
| if (includeEmoji) { |
There was a problem hiding this comment.
"No changes" becomes "+0.0%". Do you think maybe we could special case this and show (none) or (same)? Danger will skip over them but they still show up in local output. Or at least maybe lose the + if it's exact zero.
There was a problem hiding this comment.
ahh good catch, I noticed this in the original code and forgot to match it.
Test Plan: yolo? yarn danger pr didn't give me any useful output. :\
LeonYuAng3NT
pushed a commit
to LeonYuAng3NT/react
that referenced
this pull request
Mar 22, 2018
Test Plan: yolo? yarn danger pr didn't give me any useful output. :\
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
Test Plan: yolo? yarn danger pr didn't give me any useful output. :\
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: yolo? yarn danger pr didn't give me any useful output. :\