Disable for...of by default, rewrite cases where it matters #12198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Feb 9, 2018
| for (const key of Object.keys(fragment.props)) { | ||
| const keys = Object.keys(fragment.props); | ||
| for (let i = 0; i < keys.length; i++) { | ||
| const key = keys[i]; |
There was a problem hiding this comment.
Strictly saying this is the only case where it matters. But I figured changing TestRenderer code doesn't hurt too.
nhunzaker
approved these changes
Feb 9, 2018
aweary
approved these changes
Feb 9, 2018
ljharb
reviewed
Feb 9, 2018
| @@ -11,6 +11,7 @@ module.exports = { | |||
|
|
|||
| plugins: [ | |||
| 'jest', | |||
| 'no-for-of-loops', | |||
There was a problem hiding this comment.
Do you need a whole plugin for this? You can use no-restricted-syntax to block for..of loops with a custom message.
There was a problem hiding this comment.
Oh I didn’t know that. Happy to take a PR.
SadPandaBear
pushed a commit
to SadPandaBear/react
that referenced
this pull request
Feb 15, 2018
…#12198) * Add no-for-of lint rule * Ignore legit use cases of for..of * Rewrite for..of in source code
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
…#12198) * Add no-for-of lint rule * Ignore legit use cases of for..of * Rewrite for..of in source code
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Add no-for-of lint rule * Ignore legit use cases of for..of * Rewrite for..of in source code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for...ofintroduces a dependency onSymbolandSymbol.iterator(and bloated code too, withtry/catchin a potentially very hot DEV path). We accidentally merged that in #10783.I'm adding this rule so we can be more vigilant. You can ignore it for build and other scripts but please don't ignore it in the source.