-
Notifications
You must be signed in to change notification settings - Fork 49.3k
Added gatsby-plugin-nprogress for slow-loading pages (eg Blog) #10917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview ready! Built with commit 854b466 |
d652a29
to
9c3de4a
Compare
Hmm. I still see about a 1s block until it simultaneously shows the loading indicator and switches the tab. |
The 1 second delay is actually intentional
~from the docs |
If the "nit" was it's slow clicking on the blog link, this PR fixes that gatsbyjs/gatsby#2264 |
I think this plugin is probably still worth adding for other cases than the blog redirect. I'll update this PR to 1.9.49 too though to pull in the Gatsby fix. 😄 |
Yeah on slow 3g, Gatsby often can't quite load new pages fast enough so the progress indicator is nice. On anything faster, new pages are almost always loaded by the time you click on a link. |
I kinda miss the "wow" reaction from FB on GitHub because I'd totally "wow" how fast you fixed gatsbyjs/gatsby#2264. 😛 |
Can we force the bot to redeploy? |
It does automatically on git pushes so the site's already rebuilt https://deploy-preview-10917--reactjs.netlify.com/ |
It's already re-deployed. |
One way to make the progress bar show is to load the site in an incognito tab and then just click around really quickly before Gatbsy has had a chance to preload anything. |
The network tab in chrome lets you throttle the network speed as well. |
Good call. I often forget about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Adds the
gatsby-plugin-nprogress
plugin (which displays the npgoress loading bar if a page takes longer than a second to load.)This might fix the nit you mentioned, @gaearon. Let's see how it looks when Netlify adds a preview link. (Kyle also recommended this plug-in a time or two. Gatsby uses it on its own website.)