Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite test renderer docs #10916

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Rewrite test renderer docs #10916

merged 1 commit into from
Sep 28, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 28, 2017

If the docs just restate method names they're not very helpful. :-)

@gaearon gaearon requested a review from bvaughn September 28, 2017 15:21
bvaughn
bvaughn approved these changes Sep 28, 2017
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the docs just restate method names they're not very helpful. :-)

Agreed! 😄

Didn't really read the changes. Just scanned them. I trust you.

@bvaughn
Copy link
Contributor

bvaughn commented Sep 28, 2017 •
edited
Loading

I've updated this PR to merge into gatsby rather than master to avoid any possible conflicts with the large PR.

@bvaughn bvaughn changed the base branch from master to gatsby September 28, 2017 16:23
@gaearon gaearon merged commit 5c64756 into gatsby Sep 28, 2017
@gaearon
Copy link
Collaborator Author

gaearon commented Sep 28, 2017

I've updated this PR to merge into gatsby rather than master to avoid any possible conflicts with the large PR.

TIL this is editable after creating the PR

@bvaughn bvaughn deleted the gaearon-patch-14 branch September 28, 2017 17:06
@koba04
Copy link
Contributor

koba04 commented Sep 29, 2017

Thanks! 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @bvaughn @koba04 @facebook-github-bot