Remove Stack (part 4: remove Stack-only branches and types) #10798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2017
gaearon
force-pushed
the
remove-stack-again-404
branch
2 times, most recently
from
6597323 to
ec31847
Compare
gaearon
changed the title
gaearon
force-pushed
the
remove-stack-again-404
branch
from
ec31847 to
f49ad86
Compare
|
Deploy preview ready! Built with commit 0a67baa |
trueadm
approved these changes
Oct 2, 2017
|
I prepared a sync (see my last diff) and went through the test plan. Worked fine for me. |
|
@gaearon Awesome! All good on my side then – great work removing Stack :) |
gaearon
force-pushed
the
remove-stack-again-404
branch
from
f49ad86 to
0a67baa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part extracted from #10517.
The first two commits remove unnecessary injections.
The last one is somewhat extensive and removes dead files and all branching on
typeof x.tag === 'number'. It also removes precaching logic from the component tree (Stack only).validateDOMNestingtakes one less argument because Fiber always passednullinstead ofchildInstance.For tests, it fixes up
ResponderEventPlugin-test.jssince it depended on Stack internal names.