Skip to content

Delete Stack reconciler #10517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Delete Stack reconciler #10517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c48f532
Remove Fiber Jest project
gaearon Aug 23, 2017
3c0a379
Remove Stack reconciler and ReactDOMStack code
gaearon Aug 23, 2017
f4b010c
Fix tests depending on Stack internals
gaearon Aug 23, 2017
9a261c7
Remove Stack-only DEV code
gaearon Aug 23, 2017
eea00f7
Fix lint
gaearon Aug 23, 2017
19ff9dc
Fix Flow
gaearon Aug 23, 2017
227f6db
Remove usage of ReactDOMFeatureFlags.useFiber, assuming true
gaearon Aug 23, 2017
d091292
Remove findDOMNode injection and inline it
gaearon Aug 23, 2017
2148c01
Remove Stack-only code in ReactGenericBatching
gaearon Aug 23, 2017
e868e1c
Remove Stack-only code branches
gaearon Aug 23, 2017
93b1e9a
Remvoe undocumented TestUtils methods that are broken in Fiber
gaearon Aug 23, 2017
1dcaed7
Fix newly added test from master
gaearon Aug 24, 2017
4a2d836
Record sizes
gaearon Aug 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 35 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,40 @@
"version-check": "node ./scripts/tasks/version-check.js"
},
"jest": {
"projects": [
Copy link
Collaborator Author

@gaearon gaearon Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried keeping just one project but even the newest version of Jest (21 alpha) crashes with just one project so I had to inline the config back. cc @cpojer in case this is not known.

Copy link
Contributor

@thymikee thymikee Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, it's a known issue you already filed jestjs/jest#4117 😉

Copy link
Collaborator Author

@gaearon gaearon Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks. I remember a few issues were recently closed so I wasn't sure. Sorry I didn't check 😛

"<rootDir>/scripts/jest/stack.config.json",
"<rootDir>/scripts/jest/fiber.config.json"
]
"modulePathIgnorePatterns": [
"/.module-cache/",
"<rootDir>/build/",
"<rootDir>/scripts/rollup/shims/",
"<rootDir>/scripts/bench/"
],
"transform": {
".*": "./scripts/jest/preprocessor.js"
},
"setupFiles": [
"./scripts/jest/setup.js",
"./scripts/jest/environment.js"
],
"setupTestFrameworkScriptFile": "./scripts/jest/test-framework-setup.js",
"testRegex": "/__tests__/.*(\\.js|coffee|ts)$",
"moduleFileExtensions": [
"js",
"json",
"node",
"coffee",
"ts"
],
"roots": [
"<rootDir>/eslint-rules",
"<rootDir>/mocks",
"<rootDir>/scripts",
"<rootDir>/src",
"node_modules/fbjs"
],
"collectCoverageFrom": [
"src/**/*.js",
"!src/__mocks__/vendor/third_party/*.js",
"!src/test/*.js"
],
"timers": "fake"
}
}
38 changes: 0 additions & 38 deletions scripts/jest/fiber.config.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions scripts/jest/fiber.setup.js → scripts/jest/setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@

// We want to globally mock this but jest doesn't let us do that by default
// for a file that already exists. So we have to explicitly mock it.
jest.mock('ReactDOMFeatureFlags', () => {
const flags = require.requireActual('ReactDOMFeatureFlags');
return Object.assign({}, flags, {
useFiber: true,
});
});
jest.mock('ReactFeatureFlags', () => {
const flags = require.requireActual('ReactFeatureFlags');
return Object.assign({}, flags, {
Expand Down
38 changes: 0 additions & 38 deletions scripts/jest/stack.config.json
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions scripts/jest/stack.setup.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/rollup/packaging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const facebookWWWSrcDependencies = [
// these files need to be copied to the react-native build
const reactNativeSrcDependencies = [
// TODO: copy this to RN repository and delete from React
'src/renderers/shared/stack/PooledClass.js',
'src/renderers/native/PooledClass.js',
'src/renderers/shared/fiber/isomorphic/ReactTypes.js',
'src/renderers/native/ReactNativeTypes.js',
];
Expand Down
Loading