Reset instance vars before calling commit phase lifecycles #10481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
requested changes
Aug 17, 2017
acdlite
force-pushed
the
lifecycleivars
branch
from
dd70c0a to
834938e
Compare
|
@sebmarkbage Updated, now with more programming |
sebmarkbage
reviewed
Aug 17, 2017
| startPhaseTimer(finishedWork, 'componentDidMount'); | ||
| } | ||
| instance.props = finishedWork.memoizedProps; | ||
| instance.state = finishedWork.memoizedState; |
There was a problem hiding this comment.
Is there any observable way these wouldn't already be the same?
Other than the user setting them themselves? (I suppose if they do, then this is a breaking change now.)
There was a problem hiding this comment.
Not that I can think of, more concerned about the case I can't think of, like how I didn't consider error boundaries. Is this a perf concern?
There was a problem hiding this comment.
I can think of some in async mode, just not sync mode.
There was a problem hiding this comment.
What about async mode? I can't even think of them there.
sebmarkbage
reviewed
Aug 17, 2017
| startPhaseTimer(finishedWork, 'componentDidUpdate'); | ||
| } | ||
| instance.props = finishedWork.memoizedProps; | ||
| instance.state = finishedWork.memoizedState; |
sebmarkbage
approved these changes
Aug 17, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where if a component throws, its instance variables are not reset before
componentWillUnmountis called. See https://jsfiddle.net/m3pL3yaj/ for an illustration.To protect against issues like this, we should always set
this.propsandthis.stateright before calling a lifecycle method, as if they were explicit arguments.