Better messaging for componentDidCatch cross-origin errors #10447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
force-pushed
the
componentDidError-cross-origin-message
branch
from
545e6b6
to
9020177
Compare
acdlite
reviewed
Aug 12, 2017
| 'has a `crossorigin` attribute, and that it is served with the ' + | ||
| '`Access-Control-Allow-Origin: *` HTTP header. ' + | ||
| 'See https://fb.me/react-cdn-crossorigin', | ||
| "A cross-origin error was thrown so React doesn't have access to " + |
There was a problem hiding this comment.
Can we remove the "so" and make it two separate sentences?
The prior message was a bit wordy and didn't cover all cases (like the one we discovered while researching facebook#10441). We can use the new URL to explain background info on the DEV-mode technique we're using in addition to common fixes (eg crossorigin attribute for CDN scripts and Webpack devtools settings). Putting this information behind a link will allow us to more easily edit it in the future as common causes for this issue change. Resolves facebook#10441
bvaughn
force-pushed
the
componentDidError-cross-origin-message
branch
from
9020177
to
b906a0a
Compare
sebmarkbage
approved these changes
Aug 12, 2017
|
New docs page follow-up in #10457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior message was a bit wordy and didn't cover all cases (like the one we discovered while researching #10441).
We can use the new URL to explain background info on the DEV-mode technique we're using in addition to common fixes (eg
crossoriginattribute for CDN scripts and Webpackdevtoolssettings). Putting this information behind a link will allow us to more easily edit it in the future as common causes for this issue change.Resolves #10441
Note I have not yet setup the
fb.me/react-crossorigin-errorshortcut or written the content that will live there. It's been a long day and I'm taking off. Technically we can merge this at any time (to unblock the RC) and just follow-up with the link soon. Or I'll add it on Monday if we're not in a hurry. 😄