Refactor ReactMultiChild to not throw errors too #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed these when I fixed up Transaction; with the exception of ReactErrorUtils, this should be everything.
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Feb 12, 2014
With facebook#1021 and facebook#1022, I believe this makes it so React never wraps user code in a try/catch. I left in the calls to ReactErrorUtils.guard because it sounds like FB code finds them useful.
|
this was accepted internally and will merge soon |
zpao
added a commit
that referenced
this pull request
Feb 14, 2014
Refactor ReactMultiChild to not throw errors too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed these when I fixed up Transaction in d300df5; with the exception of ReactErrorUtils, this should eliminate every place where we rethrow errors. Now the purple stop sign works (see #975) to catch errors in lower-level components as well, not only at the root level.