-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uncontrolled radios #10156
Fix uncontrolled radios #10156
Changes from 1 commit
ce70f13
25cff31
84bda97
48fc77f
15228e8
dede4b6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ const propTypes = { | |
children: PropTypes.node.isRequired, | ||
title: PropTypes.node.isRequired, | ||
resolvedIn: semverString, | ||
introducedIn: semverString, | ||
resolvedBy: PropTypes.string | ||
}; | ||
|
||
|
@@ -31,6 +32,7 @@ class TestCase extends React.Component { | |
const { | ||
title, | ||
description, | ||
introducedIn, | ||
resolvedIn, | ||
resolvedBy, | ||
affectedBrowsers, | ||
|
@@ -40,13 +42,13 @@ class TestCase extends React.Component { | |
let { complete } = this.state; | ||
|
||
const { version } = parse(window.location.search); | ||
const isTestRelevant = ( | ||
const isTestFixed = ( | ||
!version || | ||
!resolvedIn || | ||
semver.gte(version, resolvedIn) | ||
); | ||
|
||
complete = !isTestRelevant || complete; | ||
complete = !isTestFixed || complete; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doing some local testing, looks like this causes a failure on line 103: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Last time I do merge conflict resolve on github :P man. |
||
|
||
return ( | ||
<section | ||
|
@@ -68,6 +70,16 @@ class TestCase extends React.Component { | |
</h2> | ||
|
||
<dl className="test-case__details"> | ||
{introducedIn && ( | ||
<dt>First broken in: </dt>)} | ||
{introducedIn && ( | ||
<dd> | ||
<a href={'https://github.com/facebook/react/tag/v' + introducedIn}> | ||
<code>{introducedIn}</code> | ||
</a> | ||
</dd> | ||
)} | ||
|
||
{resolvedIn && ( | ||
<dt>First supported in: </dt>)} | ||
{resolvedIn && ( | ||
|
@@ -100,12 +112,12 @@ class TestCase extends React.Component { | |
</p> | ||
|
||
<div className="test-case__body"> | ||
{!isTestRelevant &&( | ||
{!isTestFixed && ( | ||
<p className="test-case__invalid-version"> | ||
<strong>Note:</strong> This test case was fixed in a later version of React. | ||
This test is not expected to pass for the selected version, and that's ok! | ||
</p> | ||
)} | ||
)} | ||
|
||
{children} | ||
</div> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
import React from 'react'; | ||
|
||
import Fixture from '../../Fixture'; | ||
|
||
class RadioGroupFixture extends React.Component { | ||
constructor(props, context) { | ||
super(props, context); | ||
|
||
this.state = { | ||
changeCount: 0, | ||
}; | ||
} | ||
|
||
handleChange = () => { | ||
this.setState(({ changeCount }) => { | ||
return { | ||
changeCount: changeCount + 1 | ||
} | ||
}) | ||
} | ||
|
||
handleReset = () => { | ||
this.setState({ | ||
changeCount: 0, | ||
}) | ||
} | ||
|
||
render() { | ||
const { changeCount } = this.state; | ||
const color = changeCount === 2 ? 'green' : 'red'; | ||
|
||
return ( | ||
<Fixture> | ||
<label> | ||
<input | ||
defaultChecked | ||
name="foo" | ||
type='radio' | ||
onChange={this.handleChange} | ||
/> | ||
Radio 1 | ||
</label> | ||
<label> | ||
<input | ||
name="foo" | ||
type='radio' | ||
onChange={this.handleChange} | ||
/> | ||
Radio 2 | ||
</label> | ||
|
||
{' '} | ||
<p style={{ color }}> | ||
<code>onChange</code>{' calls: '}<strong>{changeCount}</strong> | ||
</p> | ||
<button onClick={this.handleReset}>Reset count</button> | ||
</Fixture> | ||
) | ||
} | ||
} | ||
|
||
export default RadioGroupFixture; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched to the unminified versions intentionally so was easier to step through stuff in devtools