Treat columns property as a unitless number#10115
Merged
gaearon merged 1 commit intofacebook:masterfrom Jul 11, 2017
Merged
Conversation
nhunzaker
approved these changes
Jul 6, 2017
Collaborator
|
Can't it also specify width? https://css-tricks.com/almanac/properties/c/columns/ |
Contributor
Author
|
@gaearon yes, it's a shorthand property like <div style={{ columns: 2 }} />
// Renders `columns: auto 2`If you provide an explicit pixel value it assumes you're setting the <div style={{ columns: "320px" }} />
// Renders `columns: 320px auto`Since it's already assumed that a single numerical value represents |
Contributor
|
Flex box is a good reference point. I'd be in favor of matching it. |
Collaborator
|
👍 Leaving this up to you folks |
This was referenced Oct 2, 2017
This was referenced Feb 2, 2018
This was referenced Aug 26, 2019
This was referenced Sep 4, 2019
This was referenced Sep 22, 2019
This was referenced Jan 22, 2020
This was referenced Feb 23, 2020
This was referenced Mar 18, 2020
This was referenced Mar 27, 2020
This was referenced May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10043