Skip to content

findComponentRoot warning is misleading when logged from a transaction close #767

Closed
@sophiebits

Description

@sophiebits

If findComponentRoot throws an exception during a Transaction close (specifically, in ReactMountReady.notifyAll) after the body of the transaction threw an exception, then it logs an error (using console.error) immediately, like so:

image

The error it throws is silenced by Transaction.perform in favor of the earlier error thrown by the wrapped method, but the findComponentRoot error is logged first, which is misleading.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions