React cannot be compiled with latest Google Closure Compiler

[jochenberger]

When trying to compile React 15.3.1 with the latest Closure Compiler, the following output is produced:

react.js:13694: WARNING - Misplaced @abstract annotation. only functions or non-static methods can be abstract
  getTransactionWrappers: function () {
  ^

react.js:14161: WARNING - Misplaced @abstract annotation. only functions or non-static methods can be abstract
  getTransactionWrappers: function () {
  ^

react.js:16952: WARNING - Misplaced @abstract annotation. only functions or non-static methods can be abstract
  getTransactionWrappers: null,
  ^

react.js:4782: ERROR - @nosideeffects may only appear in externs files.
  render: SpecPolicy.DEFINE_ONCE,
  ^

1 error(s), 3 warning(s)

The last one is an errors, the others are warnings.
To reproduce:

$> wget https://dl.google.com/closure-compiler/compiler-latest.zip
$> unzip compiler-latest.zip
$> wget https://cdnjs.cloudflare.com/ajax/libs/react/15.3.2/react.js
$> java -jar closure-compiler-*.jar --js react.js

[jochenberger]

See google/closure-compiler#1503, google/closure-compiler@2d596c4.

[gaearon]

Do you know how to fix this?

[jochenberger]

No, sorry. Removing the @nosideeffects annotation from ReactClass.js will make it compile, but I'm not sure if that's a valid fix. I tried to find some clue in the commit history as to who added the annotation and when, but it was already present in the "Initial public release" commit.

[jochenberger]

I think that the annotation should be removed. It is apparently Closure-Compiler-speific (https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#nosideeffects-modifies-thisarguments), but it currently serves no other purpose than to break the minification.

[jochenberger]

See also #824

[gaearon]

Can you please send a PR removing all GCC annotations?
I think GCC support was intended at some point but it's been broken for ages.

[jochenberger]

I'd appreciate if someone else could create the PR, because I don't want to sign the CLA.

[Shastel]

Probably I can do it

[jochenberger]

Still failing with React 15.3.2 (as well as 15.4.0-rc.2) and Closure Compiler v20161024.

[gaearon]

Since nobody worked on it, the issue did not advance. If you'd like to contribute please feel free to.

[Shastel]

@gaearon now i'm working on removing GCC anotations and plan to create pr tomottow or day after

[jochenberger]

thanks @Shastel

[gaearon]

Thanks!

[followdarko]

Hey guys what's the current status?