-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attributes on custom elements are not removed during the diff #6747
Comments
grassator
pushed a commit
to grassator/react
that referenced
this issue
May 11, 2016
grassator
pushed a commit
to grassator/react
that referenced
this issue
May 11, 2016
grassator
pushed a commit
to grassator/react
that referenced
this issue
May 11, 2016
jimfb
pushed a commit
that referenced
this issue
May 13, 2016
zpao
pushed a commit
to zpao/react
that referenced
this issue
Jun 8, 2016
…k#6747 (facebook#6748) (cherry picked from commit 0e889d7)
zpao
pushed a commit
that referenced
this issue
Jun 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are trying to adopt custom elements for some parts of your UI and ran into the issue that during an update to the tree, custom attributes on the the custom elements are not removed correctly as can be seen here: http://jsbin.com/ferohipaje/edit?html,output (you will need to click on "false" and then inspect the DOM node in the dev tools of the browser).
I've tracked the issue to the
_updateDOMProperties
method inReactDOMComponent.js
. It seems that there is a special check in the loop fornextProps
:But the corresponding section is missing for
lastProps
(deleting), which results in the incorrect behavior.I'm starting the work on the patch.
The text was updated successfully, but these errors were encountered: