Skip to content

<progress> requires value to be an attribute, but it's a property due to inputs #6119

Closed
@syranide

Description

@syranide

Now that #1510 has landed we still have one final issue to fix (ironically, the initial reason for #1510). #1510 (comment) + #1510 (comment), the problem being that value is managed as a property for the purpose of <input>, but <progress> requires it to be an attribute so that the attribute is correctly removed when null.

As discussed in the second comment, it seems to me that the right approach here is to actually remove all the special property logic from DOMPropertyOperations and instead implement it in the appropriate wrappers instead (ReactDOMInput, etc).

Repro: http://jsfiddle.net/670u7ure/8/
Original issue: #1431

cc @jimfb, @spicyj

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions