JSX doesn't handle an over parenthesization

[sebmarkbage]

This unit test fails.

  it('should handle parenthesis in expressions', function() {
    var code = [
      '/**',
      ' * @jsx React.DOM',
      ' */',
      '<Component x={(a)} {...(b)} y={1} />;'
    ].join('\n');
    var result = [
      '/**',
      ' * @jsx React.DOM',
      ' */',
      'Component({x: (a), ...(b), y: 1});'
    ].join('\n');

    expect(transform(code).code).toBe(result);
  });

Because this only steps past the inner expression: https://github.com/facebook/react/blob/master/vendor/fbtransform/transforms/xjs.js#L226-L227

The parenthesis is not it's own expression and therefore doesn't have a range. It's not possible to skip past the ) to insert the , after it.

[syranide]

I'm assuming you're running some internally enhanced JSX because that's not currently valid. But yeah, I could reproduce the issue. The same issue apparently also affects children:

<Component x={(a)} y={1}>a{(a)}a</Component> yields Component({x: (a, )y: 1}, "a", (a, )"a");

[sebmarkbage]

The new syntax is this thing: facebookarchive/esprima#22

[syranide]

Ah cool, I heard about your proposal, seems great!

#1674 should be a simple and correct fix I believe.

[syranide]

@sebmarkbage You fixed this quite some time ago right? Nope, this is definitely not fixed in React master at least.