Skip to content

Investigate the nested update overflow caused by coalescing #11207

Closed
@gaearon

Description

@gaearon

We had an internal issue (T22633912) which manifested itself as an infinite nested update loop triggering our invariant.

@trueadm investigated that it was introduced in #10426 and then fixed in #11187. We don’t, however, have any failing tests related to that.

Even though we removed that coalescing implementation, I feel like we need to investigate what happened and add a regression test to prevent the same issue from occurring in the future.

It might also be valuable to think about any additional information we can surface in the error, at least in development. For example, component names for last ten fibers that scheduled an update.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions