-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: undefined is not an object (evaluating 's.get.call') from input onChange - React 15.6.1 ReactDOM 15.6.0 on Safari 9.1.x #10755
Comments
Have you tried the latest version of React (15.6.1)? |
Yes. I have tried 15.6.1. Doesn't work properly on Safari.
I have tried 15.3.1 and it works
…On Wed, Sep 20, 2017 at 9:20 AM, Dan Abramov ***@***.***> wrote:
Have you tried the latest version of React (15.6.1)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10755 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGSjLC-i9vD0jFZjK9DkaYRbeio-YDM-ks5skREvgaJpZM4Pdfc9>
.
|
Which Safari version are you using? Please provide enough details. :-) |
OK. I got confused by your initial report because you did not specify the version that was broken. And so I read it thinking it‘s 15.3.1 that was broken. Is my understanding correct that:
? |
yes that is correct. And I am using Safari 9.1.2. Thank you
…On Wed, Sep 20, 2017 at 9:46 AM, Dan Abramov ***@***.***> wrote:
Yes. I have tried 15.6.1. Doesn't work properly on Safari. I have tried
15.3.1 and it works
OK. I got confused by your initial report because you did not specify the
version that was broken. And so I read it thinking it‘s 15.3.1 that was
broken.
Is my understanding correct that:
- You’re using desktop Safari (which version?)
- The error doesn’t happen with React 15.3.1
- The error happens with React 15.6.1
?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10755 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGSjLLWSEquwonvVW-8RMXn2yFp1ENj1ks5skRc_gaJpZM4Pdfc9>
.
|
This sounds a lot like the bug fixed in 15.6.1...does it work with 15.5.x? Can we get an unminified stack trace? |
@toshisugano you're using Here's a version of your Codepen running version 15.6.1 for both packages: https://codepen.io/Aweary/pen/pWyXWy I've verified that the issue does not occur in Safari 9 after updating |
Yes that was it. It is now working! Thank you so much!!!
…On Wed, Sep 20, 2017 at 11:44 AM, Brandon Dail ***@***.***> wrote:
@toshisugano <https://github.com/toshisugano> you're using react-dom
15.6.0 and react 15.6.1. Those packages should always be on the same
version, even with patch releases.
Here's a version of your Codepen running version 15.6.1 for both packages:
https://codepen.io/Aweary/pen/pWyXWy
I've verified that the issue does not occur in Safari 9 after updating
react-dom to 15.6.1. Can you confirm that this fixes your issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10755 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGSjLMpJaTmGckdxf_CXzPirozKKHMq-ks5skTL7gaJpZM4Pdfc9>
.
|
Do you want to request a feature or report a bug?
A bug
What is the current behavior?
onChange onKeyUp onKeyDown causes TypeError: undefined is not an object (evaluating 's.get.call') only in Safari.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/ebsrpraL/).
https://codepen.io/anon/pen/rGevxK
What is the expected behavior?
Component should get event.target.value and then update the state, which in turn re-renders the h1 with new state values.
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
It works for React 15.3.1 ReactDOM15.3.1
The text was updated successfully, but these errors were encountered: