Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c65b925
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 15bb962
Choose a head ref
  • 2 commits
  • 17 files changed
  • 1 contributor

Commits on Sep 7, 2021

  1. Wire up the native API for useSyncExternalStore (#22237) 

    Adds useSyncExternalStore to the internal dispatcher, and exports
the native API from the React package without yet implementing it.
    @acdlite
    acdlite authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    77912d9 View commit details
    Browse the repository at this point in the history

  2. Implement useSyncExternalStore in Fiber 

    This adds an initial implementation of useSyncExternalStore to the
fiber reconciler. It's mostly a copy-paste of the userspace
implementation, which is not ideal but is a good enough starting place.

The main change we'll want to make to this native implementation is to
move the tearing checks from the layout phase to an earlier, pre-commit
phase so that code that runs in the commit phase always observes a
consistent tree.

Follow-ups:

- Implement in Fizz
- Implement in old SSR renderer
- Implement in react-debug-hooks
    @acdlite
    acdlite committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    15bb962 View commit details
    Browse the repository at this point in the history
Loading